Eliminate O(n^2) status removal in DashboardTreeTableModel#316
Open
NicoPiel wants to merge 1 commit into
Open
Conversation
updateChannelNodes called statuses.remove(status) inside a loop over child nodes. With an ArrayList, each remove is O(n), making the update O(channels × statuses). Collected matched statuses in a HashSet and called removeAll once after the loop, reducing to O(n + m). Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
mgaffigan,
pacmano1,
ssrowe and
tonygermano
and removed request for
a team
Contributor
|
Is there an existing unit test that covers this method? If no, can you create one? |
mgaffigan
approved these changes
May 27, 2026
Contributor
mgaffigan
left a comment
mgaffigan
left a comment
There was a problem hiding this comment.
This looks fine, but was this showing up on a profiler? There's going to be a lot of changes if you are not chasing based on actual performance issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateChannelNodes called statuses.remove(status) inside a loop over
child nodes. With an ArrayList, each remove is O(n), making the update
O(channels × statuses). Collected matched statuses in a HashSet and
called removeAll once after the loop, reducing to O(n + m).